Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OrderedCollections] Update docs to state that the sort algorithm is stable #201

Merged
merged 3 commits into from
Oct 12, 2022
Merged

[OrderedCollections] Update docs to state that the sort algorithm is stable #201

merged 3 commits into from
Oct 12, 2022

Conversation

lorentey
Copy link
Member

Resolves #186.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@lorentey lorentey added OrderedCollections OrderedSet and OrderedDictionary OrderedDictionary labels Oct 11, 2022
@lorentey lorentey added this to the 1.0.4 milestone Oct 11, 2022
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey mentioned this pull request Oct 11, 2022
Closed
@benrimmington
Copy link

Should the three sort(by:) comments still refer to the areInIncreasingOrder parameter?

https://github.com/apple/swift/blob/5d832bf946bef47a1a7e894ca32b9768799f1863/stdlib/public/core/Sort.swift#L234-L236

@lorentey
Copy link
Member Author

Oops, you're absolutely right, I mistakenly lost the custom wording for the closure-taking variants. Restored!

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey merged commit 03a30ba into apple:release/1.0 Oct 12, 2022
@lorentey lorentey deleted the stable-sort branch October 12, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OrderedCollections OrderedSet and OrderedDictionary
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentey @benrimmington